fix(super-editor): preserve rows without cells when merging#3845
Open
bogdanyluk wants to merge 1 commit into
Open
fix(super-editor): preserve rows without cells when merging#3845bogdanyluk wants to merge 1 commit into
bogdanyluk wants to merge 1 commit into
Conversation
ProseMirror's `mergeCells` command can result in table rows that contain no cells. Previously, these rows were filtered out during conversion to `FlowBlock[]`, which could lead to incorrect row counts and rendering when a cell with a `rowspan` attribute covered these empty rows. This change modifies `parseTableRow` to ensure that structurally empty rows are preserved, preventing rendering issues with vertically merged cells. Fixes superdoc-dev#3782
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3782
Summary
Fixes table formatting corruption after merging multiple full-width rows in an imported DOCX.
Root cause
ProseMirror represents a full-width vertical merge as:
colspanandrowspanWhen serialized, the empty row has no
contentproperty. The layout adapter discarded this row, causing the next row to be processed while the merged columns were still occupied. AutoFit then placed its cells in additional columns, widening the table and rendering cells outside its right boundary.Fix
Screenshots
Before
After
Test Plan
.docxwith a table (from the issue).