Skip to content

refactor(painter-dom): rename rtl-paragraph feature to inline-direction (SD-2779) #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caio-pizzol merged 2 commits into from
May 14, 2026
Merged

refactor(painter-dom): rename rtl-paragraph feature to inline-direction (SD-2779) #3307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
174aa5e
refactor(painter-dom): rename rtl-paragraph feature to inline-directi…
caio-pizzol May 14, 2026
1076280
docs(direction): correct OOXML spec citations on the orthogonal-axis …
caio-pizzol May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/layout-engine/painters/dom/src/features/feature-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,14 @@ export const RENDERING_FEATURES = {
spec: '§17.3.1.31',
},

// ─── RTL Paragraph ─────────────────────────────────────────────
// ─── Inline Direction ──────────────────────────────────────────
// Paragraph/run inline bidi handling. NOT table visual direction
// (w:bidiVisual, §17.4.1), NOT writing mode (w:textDirection,
// §17.3.1.41 paragraph / §17.4.72 cell; values in §17.18.93).
// @spec ECMA-376 §17.3.1.1 (bidi), §17.3.2.30 (rtl)
'w:bidi': {
feature: 'rtl-paragraph',
module: './rtl-paragraph',
feature: 'inline-direction',
module: './inline-direction',
handles: ['w:pPr/w:bidi', 'w:rPr/w:rtl'],
spec: '§17.3.1.1',
},
Expand Down
22 changes: 22 additions & 0 deletions packages/layout-engine/painters/dom/src/features/inline-direction/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/**
* Inline Direction - rendering feature module
*
* Centralises paragraph base-direction and run-level RTL/bidi handling
* used by DomPainter:
* - Detecting whether a paragraph is RTL
* - Applying dir="rtl" and the correct text-align to an element
* - Resolving text-align for RTL vs LTR (justify -> right/left)
* - Deciding whether segment-based (absolute) positioning is safe
*
* Scope is paragraph/run inline bidi handling only. Table visual
* direction (w:bidiVisual, ECMA-376 §17.4.1) is a separate orthogonal
* axis owned by the painter's table rendering path. Writing mode
* (w:textDirection, ECMA-376 §17.3.1.41 paragraph / §17.4.72 cell;
* values in §17.18.93 ST_TextDirection) is another separate axis.
*
* @ooxml w:pPr/w:bidi - paragraph bidirectional flag
* @ooxml w:rPr/w:rtl - run-level right-to-left flag
* @spec ECMA-376 §17.3.1.1 (bidi), §17.3.2.30 (rtl)
*/

export { applyRtlStyles, shouldUseSegmentPositioning } from './rtl-styles.js';
0 .../src/features/rtl-paragraph/rtl-styles.ts → ...c/features/inline-direction/rtl-styles.ts
View file
Open in desktop
File renamed without changes.
15 changes: 0 additions & 15 deletions packages/layout-engine/painters/dom/src/features/rtl-paragraph/index.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/layout-engine/painters/dom/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ import {
stampBetweenBorderDataset,
type BetweenBorderInfo,
} from './features/paragraph-borders/index.js';
import { applyRtlStyles, shouldUseSegmentPositioning } from './features/rtl-paragraph/index.js';
import { applyRtlStyles, shouldUseSegmentPositioning } from './features/inline-direction/index.js';
import { convertOmmlToMathml } from './features/math/index.js';

/**
Expand Down
Loading