fix(direction): preserve explicit bidiVisual=false in resolveTableDirection (SD-3141)#3283
Merged
Merged
Conversation
…ection (SD-3141) resolveTableDirection previously emitted visualDirection only for the explicit-true case, conflating "no signal" with "explicit false." Per ECMA-376 section 17.4.1 + 17.17.4, w:bidiVisual w:val="0" is an explicit-false that can override a style-cascade true. Cascade-override semantics match paragraph w:bidi, which resolveParagraphDirection already handles symmetrically. The table resolver had a gap. Add the missing else-if branch so an explicit false emits visualDirection: 'ltr'. The helper getTableVisualDirection added in SD-3138 (PR #3279) already returned 'ltr' for the legacy fallback path; this aligns the resolver with the helper so Phase 1B (pm-adapter wiring of tableDirectionContext) does not silently regress the explicit-false case from 'ltr' to undefined. Tests: - rightToLeft: false -> visualDirection: 'ltr' - bidiVisual: false -> visualDirection: 'ltr' - empty input -> visualDirection: undefined - rtl wins when mixed signals present - 24 existing direction tests still pass.
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
Contributor
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.91 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.134 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0-next.136 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
🎉 This PR is included in superdoc v1.30.0-next.88 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, prerequisite for SD-3138 Phase 1B.
resolveTableDirectionpreviously emittedvisualDirectiononly for the explicit-true case, conflating "no signal" with "explicit false." Per ECMA-376 §17.4.1 + §17.17.4,w:bidiVisual w:val="0"is an explicit-false that can override a style-cascade true. The cascade-override semantic is the same as paragraphw:bidi, whichresolveParagraphDirectionalready handles symmetrically.The helper
getTableVisualDirectionadded in SD-3138 / PR #3279 already returned'ltr'for the legacy fallback path. Without this fix, Phase 1B (pm-adapter wiring oftableDirectionContext) would silently regress an explicit-false table from'ltr'toundefinedonce the context path takes over.Diff: one
else ifadded; four resolver tests covering the new branch + the unchanged paths.Tests: 29 pass (24 existing direction tests + 4 new + 1 existing rtl-mixed). No behavior change for current consumers (they read
=== 'rtl';'ltr'andundefinedboth go to the false branch).Sequencing: land before SD-3138 Phase 1B starts. Companion to SD-3142 (export-side fix for the same explicit-false semantic).