chore(ci): install pnpm in demos smoke-test job#3274
Merged
Conversation
The contract-templates demo has a predev script (`pnpm --filter superdoc build`) which the smoke-test runner invokes via `npm run dev`. Without pnpm on PATH the predev hook fails with `sh: 1: pnpm: not found` and the demo never starts, so playwright reports `Process from config.webServer was not able to start`. The build job already uses pnpm/action-setup; mirroring it in smoke-test keeps local dev UX intact (predev still works) and unblocks every PR that exercises the demos matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contract-templates demo has a
predevscript (pnpm --filter superdoc build) which the smoke-test runner invokes vianpm run dev. Without pnpm on PATH the predev hook fails withsh: 1: pnpm: not foundand the demo never starts; playwright then reportsProcess from config.webServer was not able to start. Exit code: 127.This blocks every PR that triggers the demos workflow (i.e. anything touching
demos/**or shared packages likesuper-editor,layout-engine,superdoc,react). Example: #3272.The
buildjob already usespnpm/action-setup@v4. Mirroring it insmoke-testkeeps the local dev UX intact (the predev hook still does its job) and unblocks the matrix. Two-line change.Verified locally by reading the failing job logs at https://github.com/superdoc-dev/superdoc/actions/runs/25828093178/job/75886653390 and confirming the predev script in
demos/contract-templates/package.json:6is the unique demo carrying this hook.