SD-3116 - bug: SVG image doesn't render on imported files#3268
Merged
artem-harbour merged 4 commits intoMay 14, 2026
Merged
Conversation
superdoc-bot
Bot
added
review: careful
review: quick
and removed
review: careful
labels
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
artem-harbour
deleted the
gabriel/sd-3116-bug-image-set-as-presetcontent-in-sdt-field-does-not-persist
branch
Contributor
|
🎉 This PR is included in superdoc v1.30.0-next.85 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0-next.134 |
Contributor
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.132 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.89 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.8.0-next.104 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
SVG images embedded in the document are not rendered when loading a document in SuperDoc. The root cause is: browsers expect the MIME type of SVG images to be
svg+xml, but we were rendering them assvgonly. The browser then refused to render it.Proposed solution
Like we do with other media types, we simply need to map
svgtosvg+xmlbefore converting it to base64.