fix(demos): align lucide-react across workspaces (grading-papers hydration)#3164
Merged
caio-pizzol merged 1 commit intomainfrom May 5, 2026
Merged
fix(demos): align lucide-react across workspaces (grading-papers hydration)#3164caio-pizzol merged 1 commit intomainfrom
caio-pizzol merged 1 commit intomainfrom
Conversation
…s hydration The grading-papers Next.js demo's smoke test was failing on every PR with a React hydration error: SSR and CSR rendered two different versions of the Lucide Book icon's SVG path. The workspace had three different lucide-react versions pinned (0.400.0, 0.454.0, 0.511.0). The Book icon path changed between 0.400.0 (old) and 0.454.0+ (new), which is what surfaced in the diff. Bumped demos/grading-papers and demos/collaborative-agent/client to ^0.511.0 to match examples/advanced/headless-toolbar/react-shadcn. The lockfile now resolves to a single lucide-react@0.511.0 across the three React variants in the workspace, removing the multi-version surface that allowed SSR vs CSR to disagree.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grading-papers Next.js demo's smoke test was failing on every PR with a React hydration error. Server and client rendered two different versions of the Lucide
Bookicon's SVG path:The workspace had three different lucide-react versions pinned (0.400.0, 0.454.0, 0.511.0). The Book icon's SVG path changed between 0.400.0 and 0.454.0, which is what surfaced in the hydration diff. Bumped `demos/grading-papers` and `demos/collaborative-agent/client` to `^0.511.0` to match the third workspace (`examples/advanced/headless-toolbar/react-shadcn`).
The lockfile now resolves to a single `lucide-react@0.511.0` (across React 18 / 19 variants), removing the multi-version surface that allowed the bundles to disagree.
Verified: `pnpm install` resolves cleanly to one lucide-react major; the Book icon SVG path is identical across all three React variants in node_modules; `pnpm --dir demos/grading-papers run build` completes; `pnpm --filter superdoc build` clean.