fix(types): drop accidental BasicUpload public re-export (SD-2893)#3151
Merged
caio-pizzol merged 1 commit intomainfrom May 5, 2026
Merged
fix(types): drop accidental BasicUpload public re-export (SD-2893)#3151caio-pizzol merged 1 commit intomainfrom
caio-pizzol merged 1 commit intomainfrom
Conversation
BasicUpload was re-exported through `superdoc/super-editor` and `superdoc` despite being marked `@internal` at the export site (packages/super-editor/src/editors/v1/index.js:103). It is not documented in any README, AGENTS guide, or example. The two dev components that use it (SuperdocDev.vue, DeveloperPlayground.vue) import it directly from `@superdoc/common/components/BasicUpload.vue`, not via the public re-export. Drop the re-export rather than relocating the .vue file. The upload widget is dev-tooling, not a public API. The bare `@superdoc/common/components/BasicUpload.vue` shim entry goes away because no public d.ts file references it anymore. Also removes the BasicUpload assertion from the consumer-typecheck customer-scenario fixture so the matrix stays green; the fixture was the only place the public re-export was exercised. Shim count: 3 to 2. Remaining: @superdoc/common (5 dist refs, catch-all bin), @superdoc/style-engine/ooxml (10 dist refs). Verified: build:es clean (8 guarded packages, 2 shim modules), consumer matrix 47/0/0, runtime smoke 4/4 with BasicUpload explicitly asserted absent from main and super-editor entries.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.50 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.92 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0-next.94 |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drains the fourth shim entry by removing the accidental public re-export of
BasicUpload. Shim count: 3 to 2.BasicUploadwas re-exported throughsuperdoc/super-editorandsuperdocdespite being marked@internalat the export site itself (editors/v1/index.js:103). Customer-use audit found:SuperdocDev.vue,DeveloperPlayground.vue) import it directly from@superdoc/common/components/BasicUpload.vue, never via the public re-export.Dropping the re-export is cleaner than relocating the
.vuefile because the widget is dev-tooling, not a documented public component. The shim entry for@superdoc/common/components/BasicUpload.vuegoes away because nothing on the public surface references it anymore.The consumer-typecheck
customer-scenario.tsfixture was the only place the public re-export was exercised. Removed the assertion there too so the matrix stays green; this is consistent with the SD-2828 contract that public-facing assertions track the actual public surface.Remaining shims (2):
@superdoc/common(5 dist refs, catch-all bin),@superdoc/style-engine/ooxml(10 dist refs). Each needs exploratory work, not the simple dropping or relocation pattern.Verified:
pnpm --filter superdoc build:esclean (audit OK, 8 guarded packages, 2 shim modules)assert.equal(m.BasicUpload, undefined)on bothsuperdocandsuperdoc/super-editorentries