Skip to content

fix(types): drain layout-engine and useUiFontFamily shims (SD-2893)#3140

Merged
caio-pizzol merged 1 commit intomainfrom
caio-pizzol/SD-2893-stack-2-shim-probe
May 5, 2026
Merged

fix(types): drain layout-engine and useUiFontFamily shims (SD-2893)#3140
caio-pizzol merged 1 commit intomainfrom
caio-pizzol/SD-2893-stack-2-shim-probe

Conversation

@caio-pizzol
Copy link
Copy Markdown
Contributor

Stacked on #3133. Two cheap-win follow-ups to the D1 relocation, dropping the internal shim count from 6 to 4.

  • useUiFontFamily: the bare @superdoc/composables/useUiFontFamily.js specifier only appeared in a JSDoc @example block. The example was also misleading. The composable is internal-only, not exported from any public entry, so a consumer cannot actually use the shown import. Removing the example clears the shim without changing public API.
  • @superdoc/layout-engine: relocate via the same D1 pattern as contracts and layout-bridge. The package's source only imports from @superdoc/contracts (already relocated), so a full src/**/* glob is safe and does not pull additional internal packages into the declaration graph.

Remaining shims need more evaluation than a cheap-win slice: @superdoc/common (referenced by 5 dist files including public types), common/components/BasicUpload.vue (publicly re-exported runtime component), common/list-marker-utils, and style-engine/ooxml (10 files, deep dependency).

Verified: matrix 47/0/0, build:es clean, declaration audit clean (7 guarded packages, 4 modules in shim).

@caio-pizzol caio-pizzol requested a review from a team as a code owner May 5, 2026 00:23
@linear
Copy link
Copy Markdown

linear Bot commented May 5, 2026

Base automatically changed from caio-pizzol/SD-2893-d1-shim-relocations to main May 5, 2026 00:27
@caio-pizzol caio-pizzol force-pushed the caio-pizzol/SD-2893-stack-2-shim-probe branch from 947efb9 to 9f1d0ff Compare May 5, 2026 10:43
Two cheap-win follow-ups to the D1 relocation. Shim count: 6 to 4.

useUiFontFamily: the bare @superdoc/composables/useUiFontFamily.js
specifier only appeared inside a JSDoc @example block. The example
was also misleading; this composable is not exported from any public
entry, so a consumer cannot use the shown import. Removing the
example clears the shim without changing public API.

@superdoc/layout-engine: relocate via the same D1 pattern as
contracts and layout-bridge. layout-engine only imports from
@superdoc/contracts (already relocated), so a full src/**/* glob is
safe and does not pull additional internal packages into the
declaration graph.

Remaining shims: @superdoc/common, common/components/BasicUpload.vue,
common/list-marker-utils, style-engine/ooxml. Each needs more
evaluation than a cheap-win slice.
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@caio-pizzol caio-pizzol merged commit 43d6dec into main May 5, 2026
69 checks passed
@caio-pizzol caio-pizzol deleted the caio-pizzol/SD-2893-stack-2-shim-probe branch May 5, 2026 11:17
@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.48

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in vscode-ext v2.3.0-next.92

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in @superdoc-dev/react v1.2.0-next.90

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in superdoc-cli v0.8.0-next.66

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in superdoc v1.30.0-next.49

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants