fix(types): drain layout-engine and useUiFontFamily shims (SD-2893)#3140
Merged
caio-pizzol merged 1 commit intomainfrom May 5, 2026
Merged
fix(types): drain layout-engine and useUiFontFamily shims (SD-2893)#3140caio-pizzol merged 1 commit intomainfrom
caio-pizzol merged 1 commit intomainfrom
Conversation
947efb9 to
9f1d0ff
Compare
Two cheap-win follow-ups to the D1 relocation. Shim count: 6 to 4. useUiFontFamily: the bare @superdoc/composables/useUiFontFamily.js specifier only appeared inside a JSDoc @example block. The example was also misleading; this composable is not exported from any public entry, so a consumer cannot use the shown import. Removing the example clears the shim without changing public API. @superdoc/layout-engine: relocate via the same D1 pattern as contracts and layout-bridge. layout-engine only imports from @superdoc/contracts (already relocated), so a full src/**/* glob is safe and does not pull additional internal packages into the declaration graph. Remaining shims: @superdoc/common, common/components/BasicUpload.vue, common/list-marker-utils, style-engine/ooxml. Each needs more evaluation than a cheap-win slice.
9f1d0ff to
10e7ab0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.48 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0-next.92 |
Contributor
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.90 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.8.0-next.66 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc v1.30.0-next.49 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3133. Two cheap-win follow-ups to the D1 relocation, dropping the internal shim count from 6 to 4.
@superdoc/composables/useUiFontFamily.jsspecifier only appeared in a JSDoc@exampleblock. The example was also misleading. The composable is internal-only, not exported from any public entry, so a consumer cannot actually use the shown import. Removing the example clears the shim without changing public API.@superdoc/layout-engine: relocate via the same D1 pattern as contracts and layout-bridge. The package's source only imports from@superdoc/contracts(already relocated), so a fullsrc/**/*glob is safe and does not pull additional internal packages into the declaration graph.Remaining shims need more evaluation than a cheap-win slice:
@superdoc/common(referenced by 5 dist files including public types),common/components/BasicUpload.vue(publicly re-exported runtime component),common/list-marker-utils, andstyle-engine/ooxml(10 files, deep dependency).Verified: matrix 47/0/0, build:es clean, declaration audit clean (7 guarded packages, 4 modules in shim).