fix(super-editor): correct cursor movement direction in RTL paragraphs (SD-2390)#2590
Merged
caio-pizzol merged 3 commits intomainfrom Mar 28, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 712dc822d8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/extensions/vertical-navigation/vertical-navigation.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/extensions/vertical-navigation/vertical-navigation.js
Outdated
Show resolved
Hide resolved
Set dir="rtl" on the hidden ProseMirror editor's paragraph DOM elements when paragraphProperties.rightToLeft is true. Without this, the browser's native bidi cursor handling treated all text as LTR, causing ArrowLeft to move the cursor visually right and ArrowRight visually left in Arabic text. Also fix resolvePositionAtGoalX binary search for vertical navigation (up/down arrows) to invert search direction in RTL paragraphs where X coordinates decrease with increasing PM positions. SD-2390
Read RTL direction from the visual DOM element (set by DomPainter using resolved style properties) instead of calling doc.resolve(pmStart) inside the binary search helper. This fixes two review findings: 1. Eliminates RangeError crash when pmStart is stale (layout-derived positions can lag the current document after edits) 2. Correctly detects style-inherited RTL direction (not just inline paragraphProperties.rightToLeft) Also consolidates the duplicated makeRtlEditor test helper into the existing makeEditor, since isRtl is now a simple boolean parameter.
caio-pizzol
force-pushed
the
caio/sd-2390-fix-rtl-cursor-movement-in-presentation-mode
branch
2 times, most recently
from
4786f2a to
080474a
Compare
…ment Add Playwright behavior test that verifies ArrowLeft/ArrowRight move the cursor in the correct visual direction in RTL paragraphs (and regression test for LTR). Add visual regression test that screenshots cursor position after arrow navigation in an RTL document. Both use the existing rtl-mixed-bidi.docx fixture. SD-2390
caio-pizzol
force-pushed
the
caio/sd-2390-fix-rtl-cursor-movement-in-presentation-mode
branch
from
080474a to
3e27493
Compare
caio-pizzol
deleted the
caio/sd-2390-fix-rtl-cursor-movement-in-presentation-mode
branch
Contributor
|
🎉 This PR is included in vscode-ext v1.1.0-next.34 |
Contributor
|
🎉 This PR is included in superdoc v1.24.0-next.33 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.5.0-next.33 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.3.0-next.33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set dir="rtl" on the hidden ProseMirror editor's paragraph DOM elements when paragraphProperties.rightToLeft is true. Without this, the browser's native bidi cursor handling treated all text as LTR, causing ArrowLeft to move the cursor visually right and ArrowRight visually left in Arabic text.
Also fix resolvePositionAtGoalX binary search for vertical navigation (up/down arrows) to invert search direction in RTL paragraphs where X coordinates decrease with increasing PM positions.