fix: correct spacing for paragraphs with borders/shades#2586
Merged
caio-pizzol merged 7 commits intomainfrom Mar 28, 2026
Merged
fix: correct spacing for paragraphs with borders/shades#2586caio-pizzol merged 7 commits intomainfrom
caio-pizzol merged 7 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d0ae93d45
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Per ECMA-376 §17.3.1.42, paragraph border space is measured from the text edge "ignoring any spacing above/below". This means border expansion should overlap with spacingBefore/After, not stack on top. - Reduce top border expansion by the amount spacingBefore already covers - Reduce effective spacingAfter by the bottom border expansion - Subtract border expansion from sliceLines available height to prevent page-bottom overflow - Include border expansion in keepLines height calculation
Three fixes from self-review: - fragment.y now uses extraTop (overlap-adjusted) instead of full borderExpansion.top, so cursorY reaches the visual bottom exactly - Track spacingAppliedThisFragment to avoid under-counting border expansion on continuation fragments after page breaks - keepLines fitsOnBlankPage uses overlap model (max instead of add) to avoid unnecessary page breaks for bordered paragraphs
borderExpansion was declared inside the while loop but referenced in the spacingAfter block outside it, causing a ReferenceError. Move it before the loop so it's accessible in both places.
Layout engine: - Detect between-border groups by comparing adjacent paragraph border hashes. When borders match, suppress top expansion and reclaim previous paragraph's bottom expansion. - Border expansion is additive with spacing for non-grouped paragraphs (matches Word behavior). - Add lastParagraphBorderHash to PageState for group tracking. Renderer (group-analysis.ts): - Remove requirement for `between` border element to be present for grouping. Per ECMA-376 §17.3.1.5, grouping occurs when all border properties are identical — a between border is optional. - When no between border is defined, suppress bottom/top borders and render as a single continuous box.
…tween element The test expected no grouping when `between` border is absent. Updated to expect grouping with suppressBottomBorder per ECMA-376 §17.3.1.5: identical borders form a group regardless of whether a between border is defined.
caio-pizzol
force-pushed
the
caio-pizzol/SD-2106-paragraph-border-spacing
branch
from
cbcb1ee to
5d8880a
Compare
layout-engine cannot import from pm-adapter (boundary removed in #2618). Define PX_PER_PT locally, same as border-layer.ts does.
caio-pizzol
force-pushed
the
caio-pizzol/SD-2106-paragraph-border-spacing
branch
from
0203512 to
2b6014d
Compare
Contributor
|
🎉 This PR is included in vscode-ext v1.1.0-next.35 |
Contributor
|
🎉 This PR is included in superdoc v1.24.0-next.34 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.5.0-next.34 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.3.0-next.34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.