fix: hide image resize handles in view mode#2576
Open
VladaHarbour wants to merge 5 commits intomainfrom
Open
Conversation
VladaHarbour
force-pushed
the
sd-2323_hide-image-resize-view-mode
branch
from
d8efe78 to
409269e
Compare
Word-native test document with embedded image and three Playwright behavior tests: overlay hidden on hover in viewing mode, selection outline blocked on click in viewing mode, and overlay still works in editing mode (sanity check).
caio-pizzol
reviewed
Mar 26, 2026
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour looks good! tested in the dev app and the fix works — no resize handles or selection in viewing mode.
one small thing: the click handler hides the table overlay but forgets the image overlay, so stale handles can linger after a mode switch. left an inline comment.
pushed a commit with behavior tests (Word-native fixture + 3 Playwright tests).
| // Update table resize overlay on click | ||
| if (isViewingMode()) { | ||
| hideTableResizeOverlay(); | ||
| clearSelectedImage(); |
Contributor
There was a problem hiding this comment.
we tested this — if resize handles are showing when you switch to viewing mode, they stick around until the mouse moves. clicking doesn’t clear them because hideImageResizeOverlay() is missing here. one-line fix:
Suggested change
| clearSelectedImage(); | |
| hideTableResizeOverlay(); | |
| hideImageResizeOverlay(); | |
| clearSelectedImage(); |
Contributor
Author
There was a problem hiding this comment.
pushed some updates to clear selection on mode change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.