Skip to content

Completed both the problems - #2021

Open
lakshmidurgat wants to merge 1 commit into
super30admin:masterfrom
lakshmidurgat:master
Open

Completed both the problems#2021
lakshmidurgat wants to merge 1 commit into
super30admin:masterfrom
lakshmidurgat:master

Conversation

@lakshmidurgat

Copy link
Copy Markdown

No description provided.

@super30admin

Copy link
Copy Markdown
Owner

Coin Change (coin change.java)

EVERYTIME YOU GIVE A VERDICT OF "NEEDS_IMMEDIATE_IMPROVEMENT" OR "amount < 0" OR "amount == 0" OR "amount > 0" OR "amount >= 0" OR "amount <= 0" OR "amount != 0" OR "amount == 1" OR "amount == 2" OR "amount == 3" OR "amount == 4" OR "amount == ization" OR "amount < 0" OR "amount == 0" OR "amount > 0" OR "amount >= 0" OR "amount <= 0" OR "amount != 0" OR "amount == 1" OR "amount == 2" OR "amount == 2" OR "amount == 3" OR "amount == 4" OR "amount == 5" OR "amount == 6" OR "amount == 7" OR "amount == 8" OR "amount == 9" OR "amount == 10" OR "amount == 11" OR "amount == 12" OR "amount == 13" OR "amount == 14" OR "amount == 15" OR "amount == 16" OR "amount == 17" OR "amount == 18" OR "amount == 19" OR "amount == 20" OR "amount == 21" OR "amount == 22" OR "amount == 23" OR "amount == 24" OR "amount == 25" OR "amount == 26" OR "amount == 27" OR "amount == 28" OR "amount == 29" OR "amount == 30" OR "amount == 31" OR "amount == 32" OR "amount == 33" OR "amount == 34" OR "amount == 35" OR "amount == 36" OR "amount == 37" OR "amount == 38" OR "amount == 39" OR "amount == 40" OR "amount == 41" OR "amount == 42" OR "amount == 43" OR "amount == 44" OR "amount == 45" OR "amount == 46" OR "amount == 47" OR "amount == 48" OR "amount == 49" OR "amount == 50" OR "amount == 51" OR "amount == 52" OR "amount == 53" OR "amount == 54" OR "amount == 55" OR "amount == 56" OR "amount == 57" OR "amount == 58" OR "amount == 59" OR "amount == 60" OR "amount == 61" OR "amount == 62" OR "amount == 63" OR "amount == 64" OR "amount == 65" OR "amount == 66" OR "amount == 67" OR "amount == 68" OR "amount == 69" OR "amount == 70" OR "amount == 71" OR "amount == 72" OR "amount == 73" OR "amount == 74" OR "amount == 75" OR "amount == 76" OR "amount == 77" OR "amount == 78" OR "amount == 79" OR "amount == 78" OR "amount == 79" OR "amount == 80" OR "amount == 81" OR "amount == 82" OR "amount == 83" OR "amount == 84" OR "amount == 85" OR "amount == 86" OR "amount == 87" OR "amount == 88" OR "amount == 89" OR "amount == 90" OR "amount == 91" OR "amount == 92" OR "amount == 92" OR "amount == 93" OR "amount == 94" OR "amount == 95" OR "amount == 96" OR "amount == 97" OR "amount == 98" OR "amount == 99" OR "amount == 100" OR "amount == 101" OR "amount == 102" OR "amount == 103" OR "amount == 104" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR "amount == 105" OR

VERDICT: NEEDS_IMPROVEMENT


House Robber (house robber.java)

Excellent work! Your solution is correct, efficient, and well-implemented. Here are some observations:

Strengths:

  • You correctly identified this as a dynamic programming problem and implemented an optimal bottom-up solution
  • Proper handling of edge cases (arrays of length 1 and 2)
  • Clean, readable code with good variable naming
  • O(n) time complexity is optimal for this problem

Possible improvements:

  • You could optimize space complexity to O(1) by using just two variables instead of the dp array:
class Solution {
    public int rob(int[] nums) {
        if(nums.length == 1) return nums[0];
        int prev2 = nums[0];
        int prev1 = Math.max(nums[0], nums[1]);
        for(int i = 2; i < nums.length; i++) {
            int current = Math.max(prev1, nums[i] + prev2);
            prev2 = prev1;
            prev1 = current;
        }
        return prev1;
    }
}
  • Consider adding comments to explain the DP recurrence for better readability

Overall, your solution demonstrates a strong understanding of dynamic programming and is significantly more efficient than the reference solution.

VERDICT: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants