fix: don't stop the pool if config change request didn't change anything#760
Closed
fix: don't stop the pool if config change request didn't change anything#760
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def update_tenant_with_restart(%Tenant{} = tenant, attrs) do | ||
| changeset = Tenant.changeset(tenant, attrs) | ||
|
|
||
| # TODO: Consider checking if specific changed fields require restart. |
Check warning
Code scanning / Credo
Found a TODO tag in a comment: # TODO: Consider checking if specific changed fields require restart. Warning
abc3
reviewed
Oct 26, 2025
| |> case do | ||
| {:ok, tenant} -> | ||
| # Clear cache after creating tenant to ensure cached "not found" results are invalidated | ||
| cleanup_result = Supavisor.del_all_cache_dist(tenant.external_id) |
Contributor
There was a problem hiding this comment.
maybe this is a good time to make del_all_cache_dist non gradual
| {:ok, tenant} | ||
| else | ||
| # Clear cache before update | ||
| cleanup_result = Supavisor.del_all_cache_dist(tenant.external_id) |
Contributor
There was a problem hiding this comment.
why clear cache before update?
Member
Author
|
I'll close this as stale. We need a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.