Merged
Conversation
Using the cache when a RealtimeChannel is joined instead of keeping it under UserSocket assigns
edgurgel
force-pushed
the
fix/realtime-channel-limit-update
branch
from
95afb1d to
6b80621
Compare
filipecabaco
approved these changes
Jan 20, 2026
Member
|
🎉 This PR is included in version 2.71.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix the way we check for connection and channel limit.
This PR changes so that we we simply use the tenant cache instead of keeping it stored as part of the socket assigns.
It also ensures that we only check for max concurrent users when it's the first time joining a channel. Once the transport pid has been tracked we don't check again.