refactor(ansible): extract AWS CLI install bundle into internal/insta…#2153
Open
dliappis wants to merge 2 commits into
Open
refactor(ansible): extract AWS CLI install bundle into internal/insta…#2153dliappis wants to merge 2 commits into
dliappis wants to merge 2 commits into
Conversation
…ll-aws-cli.yml Move the 6 inline AWS CLI / amazon-ec2-utils tasks from ansible/tasks/setup-supabase-internal.yml into a single ansible/tasks/internal/install-aws-cli.yml file. Behavior preserved: - AWS CLI + amazon-ec2-utils still run under the same conditions (parent import gated on debpkg_mode or nixpkg_mode). - ec2-instance-connect is intentionally NOT moved; it stays as a top-level task in playbook.yml with its existing aws-only tag and 'when: qemu_mode is undefined' gate. Tags preserved: - AWS CLI tasks + amazon-ec2-utils continue to inherit only 'install-supabase-internal' via the parent import in playbook.yml. The import line inside setup-supabase-internal.yml carries no additional tags, matching the pre-refactor semantics. Motivation: collecting these 6 tasks into a single file makes the ansible boundary cleaner and is a small step toward per-component task files (the larger setup-supabase-internal.yml decomposition already underway via internal/*.yml). Cross-repo scan (postgres + supabox + salt) shows no broken references: - supabox-playbook.yml only mentions amazon-ec2-utils in a comment; the supabox build skips this path by not importing setup-supabase-internal.yml. - salt repo has zero references to install-supabase-internal or aws-only.
Contributor
Author
|
I did a small sanity check by comparing tasks created via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor (ansible task structure, no behavior change).
What is the current behavior?
A number of AWS install/setup tasks live inside
ansible/tasks/setup-supabase-internal.yml, mixed in with the rest of the supabase-internal install steps. There's no atomic "AWS CLI install bundle" boundary.What is the new behavior?
Same install behavior. The AWS tasks now live in a dedicated
ansible/tasks/internal/install-aws-cli.yml, imported from the same spot insetup-supabase-internal.yml.This lays cleaner boundaries for future postgres AMI runtime decomposition work, without changing any install behavior, conditionals, or tags.
Preserved precisely:
Install Supabase specific contentimport still gates onwhen: debpkg_mode or nixpkg_mode. The new file inherits this implicitly.import_tasksline carries no extra tags, so the moved tasks continue to inherit onlyinstall-supabase-internalfrom the outermost wrapper — identical to before.ec2-instance-connectin playbook.yml is intentionally not moved. It stays as a top-level task inplaybook.ymlwith its existingaws-onlytag andwhen: qemu_mode is undefinedgate. (Moving it would have changed tag semantics with possible risk hence out of scope for this refactor.)Additional context
Related https://linear.app/supabase/project/postgres-ami-runtime-decomposition-90ecfc1d03d4/overview