-
-
Notifications
You must be signed in to change notification settings - Fork 242
fix: prevent non-superuser roles from dropping supabase_privileged_role #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
utkarash2991
wants to merge
1
commit into
develop
Choose a base branch
from
fix/psql-1205-reserved-privileged-role
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| -- verify non-superuser postgres role cannot drop supabase_privileged_role | ||
| BEGIN; | ||
| -- Switch to the postgres role (non-superuser) to test supautils behavior | ||
| SET ROLE postgres; | ||
| -- SAVEPOINT is needed to recover from the expected error and continue the transaction | ||
| SAVEPOINT before_drop; | ||
| DROP ROLE supabase_privileged_role; | ||
| ERROR: "supabase_privileged_role" is a reserved role, only superusers can modify it | ||
| ROLLBACK TO SAVEPOINT before_drop; | ||
| RESET ROLE; | ||
| SELECT rolname FROM pg_roles WHERE rolname = 'supabase_privileged_role'; | ||
| rolname | ||
| -------------------------- | ||
| supabase_privileged_role | ||
| (1 row) | ||
|
|
||
| ROLLBACK; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| -- verify non-superuser postgres role cannot drop supabase_privileged_role | ||
| BEGIN; | ||
|
|
||
| -- Switch to the postgres role (non-superuser) to test supautils behavior | ||
| SET ROLE postgres; | ||
|
|
||
| -- SAVEPOINT is needed to recover from the expected error and continue the transaction | ||
| SAVEPOINT before_drop; | ||
| DROP ROLE supabase_privileged_role; | ||
| ROLLBACK TO SAVEPOINT before_drop; | ||
|
|
||
| RESET ROLE; | ||
|
|
||
| SELECT rolname FROM pg_roles WHERE rolname = 'supabase_privileged_role'; | ||
|
|
||
| ROLLBACK; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.