fix: null body crash, null config guard, and roles querystring schema mismatch#1091
Open
PedroHenrique0713 wants to merge 1 commit into
Open
Conversation
… mismatch fix(query): guard against null request body in errorOnEmptyQuery. request.body.query on null body caused TypeError instead of the intended 'query not found' error. fix(query): guard request.body.ast with optional chaining in /deparse. No validation or guard before accessing request.body.ast. fix(PostgresMetaRoles): guard config against null (not just undefined). config !== undefined allowed null through, causing config.map() TypeError. fix(roles): align querystring schema field name with handler. Schema declared include_system_schemas but handler read include_default_roles.
PedroHenrique0713
requested review from
a team,
avallete and
soedirgo
as code owners
July 23, 2026 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four fixes in postgres-meta.
routes/query.tserrorOnEmptyQuerycrashed on null body —null.queryTypeError instead of intended error messageroutes/query.ts/deparseroute had no null guard onrequest.body.astPostgresMetaRoles.tsconfig !== undefinedallowed null through →null.map()TypeErrorroutes/roles.tsinclude_system_schemasbut handler readinclude_default_roles— validated field never used