Skip to content

feat(cli): port pg-delta catalog cache #5932

Open
7ttp wants to merge 4 commits into
supabase:developfrom
7ttp:fix/port-pgdelta-catalog-cache-ts
Open

feat(cli): port pg-delta catalog cache #5932
7ttp wants to merge 4 commits into
supabase:developfrom
7ttp:fix/port-pgdelta-catalog-cache-ts

Conversation

@7ttp

@7ttp 7ttp commented Jul 22, 2026

Copy link
Copy Markdown
Member

TL;DR:

Ports the catalog cache to native TS the recent db push port #5715
left this Go feature out entirely this restores/extends it....

What's Introduced?

Basically, we're porting Go's pg-delta migrations-catalog cache to native TS,
and for that we've introduced:

legacyTryCacheMigrationsCatalog in legacy-pgdelta.cache.ts (gated on pg-delta being enabled,
reusing the legacyExportCatalogPgDelta so it can't inherit the /workspace mount bug fixed separately on the Go)
the corresponding edge-runtime/docker/ssl-probe layer wiring in push.layers.ts, the actual call site in push.handler.ts (after a successful migration apply, warns and never fails the push on error)

also added integration + unit test coverage in push.integration.test.ts and legacy-pgdelta.cache.unit.test.ts
for the enabled/disabled/failure paths and the new pure helpers....

Ref:

@7ttp
7ttp requested a review from a team as a code owner July 22, 2026 22:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddb6f8be34

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/cli/src/legacy/commands/db/push/push.handler.ts
@7ttp 7ttp self-assigned this Jul 22, 2026
@7ttp

7ttp commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0dd3a1359

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/cli/src/legacy/commands/db/push/push.handler.ts
Comment thread apps/cli/src/legacy/commands/db/push/SIDE_EFFECTS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db push: "failed to cache migrations catalog" — pg-delta can't read pgdelta-target-ca.crt inside edge-runtime (ENOENT at /workspace/...)

1 participant