feat(cli): port pg-delta catalog cache #5932
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddb6f8be34
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0dd3a1359
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
TL;DR:
Ports the catalog cache to native TS the recent
db pushport #5715left this Go feature out entirely this restores/extends it....
What's Introduced?
Basically, we're porting Go's pg-delta migrations-catalog cache to native TS,
and for that we've introduced:
legacyTryCacheMigrationsCataloginlegacy-pgdelta.cache.ts(gated on pg-delta being enabled,reusing the
legacyExportCatalogPgDeltaso it can't inherit the/workspacemount bug fixed separately on the Go)the corresponding
edge-runtime/docker/ssl-probelayer wiring inpush.layers.ts, the actual call site inpush.handler.ts(after a successful migration apply, warns and never fails the push on error)also added integration + unit test coverage in
push.integration.test.tsandlegacy-pgdelta.cache.unit.test.tsfor the enabled/disabled/failure paths and the new pure helpers....
Ref: