Skip to content

fix(pretty-print): preserve quoted policy names #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psteinroe merged 1 commit into from
May 31, 2026
Merged

fix(pretty-print): preserve quoted policy names #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions crates/pgls_pretty_print/src/nodes/alter_policy_stmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ pub(super) fn emit_alter_policy_stmt(e: &mut EventEmitter, n: &AlterPolicyStmt)
e.space();

// Policy name
if !n.policy_name.is_empty() {
e.token(TokenKind::IDENT(n.policy_name.clone()));
}
super::emit_identifier_maybe_quoted(e, &n.policy_name);

// Table name
if let Some(ref table) = n.table {
Expand Down
2 changes: 1 addition & 1 deletion crates/pgls_pretty_print/src/nodes/create_policy_stmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ pub(super) fn emit_create_policy_stmt(e: &mut EventEmitter, n: &CreatePolicyStmt
e.space();
e.token(TokenKind::POLICY_KW);
e.space();
e.token(TokenKind::IDENT(n.policy_name.clone()));
super::emit_identifier_maybe_quoted(e, &n.policy_name);

e.line(LineType::SoftOrSpace);
e.token(TokenKind::ON_KW);
Expand Down
1 change: 1 addition & 0 deletions crates/pgls_pretty_print/tests/data/single/alter_policy_quoted_name_0.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER POLICY "Public can read stats" ON my_table USING (true);
1 change: 1 addition & 0 deletions crates/pgls_pretty_print/tests/data/single/create_policy_quoted_name_0.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CREATE POLICY "Public can read stats" ON my_table FOR SELECT USING (true);
5 changes: 5 additions & 0 deletions crates/pgls_pretty_print/tests/snapshots/single/tests__alter_policy_quoted_name_0_100.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
source: crates/pgls_pretty_print/tests/tests.rs
input_file: crates/pgls_pretty_print/tests/data/single/alter_policy_quoted_name_0.sql
---
alter policy "Public can read stats" on my_table using (true);
5 changes: 5 additions & 0 deletions crates/pgls_pretty_print/tests/snapshots/single/tests__alter_policy_quoted_name_0_80.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
source: crates/pgls_pretty_print/tests/tests.rs
input_file: crates/pgls_pretty_print/tests/data/single/alter_policy_quoted_name_0.sql
---
alter policy "Public can read stats" on my_table using (true);
5 changes: 5 additions & 0 deletions crates/pgls_pretty_print/tests/snapshots/single/tests__create_policy_quoted_name_0_100.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
source: crates/pgls_pretty_print/tests/tests.rs
input_file: crates/pgls_pretty_print/tests/data/single/create_policy_quoted_name_0.sql
---
create policy "Public can read stats" on my_table as permissive for select to public using (true);
10 changes: 10 additions & 0 deletions crates/pgls_pretty_print/tests/snapshots/single/tests__create_policy_quoted_name_0_80.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
source: crates/pgls_pretty_print/tests/tests.rs
input_file: crates/pgls_pretty_print/tests/data/single/create_policy_quoted_name_0.sql
---
create policy "Public can read stats"
on my_table
as permissive
for select
to public
using (true);
Loading