fix(workspace): back off unreachable database diagnostics#746
Merged
Conversation
juleswritescode
approved these changes
May 27, 2026
Collaborator
juleswritescode
left a comment
There was a problem hiding this comment.
LGTM — one concern: we're still using get_current_connection() a whole bunch in server.rs, for example when we fetch diagnostics or completions. We should probably migrate that to with_pool as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent DB-backed workspace operations from retrying a known-unreachable database connection on every edit. Connection failures are cached per connection key in the connection manager with exponential backoff, and DB callers now route through the manager so failures are tracked consistently.
Diagnostics Resilience
Database-backed file diagnostics are best-effort. When the database is unreachable, parser and static diagnostics are still returned instead of failing the whole edit-triggered diagnostics request.
Connection Manager Routing
DB-backed diagnostics, schema-aware static analysis, splinter, completions, hover, statement execution, and schema-cache invalidation now use
ConnectionManager::with_pool, so connection failure backoff is managed centrally.Regression Coverage
Added a workspace test that points at a closed local Postgres port, verifies static diagnostics are still produced, and confirms the second diagnostics pull during backoff completes quickly.