Add help text to the DynamicFormType#345
Closed
FlorianBoe wants to merge 2 commits intosulu:2.6from
Closed
Conversation
Author
|
To be honest, I'm not quite sure how to fix the PHP Lint error. Why is there a problem with I would be grateful for support! |
Member
|
@FlorianBoe you can ignore at current state the phpstan issues for this PR :) Did not yet have deep look at it. But we require a line in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
I have added the help property to the DynamicFormType. The field is displayed below the rest of the form fields. The field type is
text_editorand the information is set to thehelpproperty of Symfony forms, with thehelp_htmloption enabled.I tried to implement the property analog to placeholders. Feel free to look over it again thoroughly, I'll be honest, I haven't looked closely at the details of the whole implementation.
Why?
Editors can now add additional help text to form fields.
To Do