Increase test coverage for js-export/interface.js and fix test harness for real constraints#5118
Closed
varruunnn wants to merge 2 commits intosugarlabs:masterfrom
Closed
Increase test coverage for js-export/interface.js and fix test harness for real constraints#5118varruunnn wants to merge 2 commits intosugarlabs:masterfrom
varruunnn wants to merge 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Contributor
|
Closed pull request due to inactivity for more than 63 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive Jest coverage for js/js-export/interface.js, raising coverage from near 15% to 90%+ by exercising real block-to-JS argument validation logic.
Key changes:
Loads constraints.js against the real JSInterface in tests (via global.JSInterface) so _methodArgConstraints and overload rules are available, matching the browser runtime.
Removes the previous test override that wiped constraint data and prevented validateArgs() from executing real logic.
Adds tests covering coercion, clamping, solfege/letter parsing, accidentals, noise/synth/drum enums, async function validation, and overloaded signatures.
CLOSES #5115