Fix delayed UI update by handling state cleanup on click#5107
Closed
021nirav-blip wants to merge 70 commits intosugarlabs:masterfrom
Closed
Fix delayed UI update by handling state cleanup on click#5107021nirav-blip wants to merge 70 commits intosugarlabs:masterfrom
021nirav-blip wants to merge 70 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
This seems to resolve the issue but you need to fix some linting issues. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
* feat: Upgrade Horizontal Scrolling to Omnidirectional Scrolling - Replaces 'Horizontal Scrolling' with 'Omnidirectional Scrolling' - Enables simultaneous X and Y scrolling (diagonal panning) when enabled in Advanced Mode - Restricts scrolling to Vertical-only in Beginner Mode or when disabled - Updates UI strings, tooltips, and Pie Menu labels to reflect the new functionality * style: Remove redundant JSDoc comment in activity.js * Linitng changes * Keeping the Horizontal name intact * Linting changes
…abs#5138) * Fix i18n: Add missing Telugu translation and localize confirm and cancel buttons * Add Telugu translation for 'Clear Workspace'
* Fix broken Music Blocks Guide link (404) * Format turtledefs.js with Prettier * Update guide link to Docs/guide after docs refactor * fixed(turtle) link: --------- Co-authored-by: Walter Bender <walter@sugarlabs.org>
* Added a Pie menu for Rhythm Maker * Remove accidentally committed .DS_Store files * Enable Type Functionality for Rhythm Maker * Moved the Piemenu code to piemenus.js * Ignore macOS .DS_Store files
* Fix auxiliary menu crash in non-English locales * Fix ESLint/Prettier formatting in js/activity.js
…abs#5018) * refactor: extract responsive breakpoint widths into constants - Add BREAKPOINT_TABLET (768px) and BREAKPOINT_MOBILE (600px) constants - Replace 5 hardcoded breakpoint values with named constants - Improves code maintainability and prevents magic numbers Affected lines: 769, 776, 787, 794, 856 in js/activity.js * changing to a much verbose variable name
Update Babel toolchain dependencies: - @babel/core: 7.11.1 → 7.28.5 - @babel/eslint-parser: 7.26.10 → 7.28.5 - @babel/preset-env: 7.11.0 → 7.28.5 - Remove deprecated babel-eslint package Fixes sugarlabs#5148 Part of sugarlabs#4668
- Remove unused variables in SaveInterface.js (savedNotationOutput, savedNotationNotes) - Remove legacy ES5 Object.keys fallback with const reassignment bug in logo.js - Fix superfluous arguments passed to __clear() function Follow-up to sugarlabs#4942 addressing Copilot code review suggestions. All changes verified with lint and full test suite (2275/2275 tests passed).
…5070) * Improve Tremolo block tooltip with parameter explanations * Improve Tremolo block tooltip for translation-friendliness
* fix: instant theme switching without page reload * Fix canvas background not updating on theme switch * Refactor theme application to use arrow functions * Refactor themebox test for consistency and clarity * Refactor getItem mock implementation in tests Refactor jest.spyOn for getItem to improve readability. * Refactor themebox test for improved readability * prettier --------- Co-authored-by: Walter Bender <walter@sorceo.com>
…ject helper (sugarlabs#4995) * refactor: replace unsafe eval with resolveObject helper in utils.js * refactor: replace safeEval's eval() with new Function() * revert: keep original eval in safeEval, focus PR on resolveObject only * refactor: move resolveObject to module scope * fix(utils): improve resolveObject error handling and environment support * fix(utils): add fallback resolution for nested class properties The resolveObject helper failed to resolve certain nested static class properties (e.g. Turtles.TurtlesView), resulting in missing methods such as doScale during initialization. This change adds a narrow fallback for cases where safe property resolution returns undefined, restoring previous behavior while keeping the primary resolution path intact. Addresses initialization failure reported during review. * style: apply prettier formatting to utils.js
…s#5165) * Fixed text color in light mode * fix: help widget in dark mode and overall text coloring * fix prettier formatting
* Update PO, POT, and JSON files to standardize 'Media' and 'Sensors' labels * Fix 'media' and 'sensors' labels and inconsistencies
* pitch comparison for tied chords * chore: retrigger CI * chore: retrigger CI * chore: format js/turtle-singer.js with CI Prettier
- cssnano: 6.0.1 → 6.1.2 (minor update) - Remove clean-css: unused direct dependency (gulp-clean-css bundles its own) Part of sugarlabs#4668
…ugarlabs#4990) * Fix: Resolve p5/Tone.js conflict using adapter pattern * style: apply prettier formatting to adapter files
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Optimizes the _testConnectionType method in js/blocks.js by replacing a linear series of string comparisons with a constant-time Set lookup. This reduces complexity and improves maintainability.
- Remove global doSearch() call from index.html that was causing race condition - Add proper activity.doSearch() initialization in RequireJS domReady flow - Fix 2 failing Jest tests in abc.test.js by correcting expected string values - All 26 tests now pass (was 24 passing, 2 failing)
Moves block interaction state cleanup from mouseout to click, fixing delayed sidebar expansion and contraction. Previously, UI state updates were triggered on mouseout, which only fires when the cursor moves away. This caused the sidebar to update late. Handling the cleanup on click makes the UI respond immediately. Fixes sugarlabs#3499
021nirav-blip
force-pushed
the
fix-mouse-responce-issue
branch
from
6867db7 to
bcaabc0
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender please review this PR |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Please make a clean PR with just the relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Moves block interaction state cleanup from
mouseouttoclick,fixing delayed sidebar expansion and contraction.
Why this is needed
Previously, UI state updates were triggered on
mouseout, which onlyfires when the cursor moves away. This caused the sidebar to update late.
Handling the cleanup on click makes the UI respond immediately.
How to test
Fixes #3499