Merged
Conversation
The current yaml-cpp tagged version is interferring with the currently unrolling CMake wrecking ball that is 4.0; which has deprecated all CMake scripts that tag to versions <3.5. That is the case for the yaml-cpp commit that we're currently pointing at. Bumping `yaml-cpp` to fetch in their new version span of `3.4...3.14`.
EpsilonPrime
approved these changes
Apr 3, 2025
mortbopet
added a commit
to mortbopet/substrait-mlir-contrib
that referenced
this pull request
Apr 4, 2025
To mitigate substrait-io/substrait-cpp#135 that currently is a transitive issue for this repo.
mortbopet
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Apr 4, 2025
To mitigate substrait-io/substrait-cpp#135 that currently is a transitive issue for this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current yaml-cpp commit is interfering with the currently unrolling wrecking ball that is CMake 4.0; which has deprecated all CMake scripts that tag to versions <3.5. That is the case for the yaml-cpp commit that we're currently pointing at.
Bumping
yaml-cppto fetch in their new version span of3.4...3.14.