Skip to content

New tabulation framework#23

Open
EvertBunschoten wants to merge 29 commits into
developfrom
fix_LUT_twophase
Open

New tabulation framework#23
EvertBunschoten wants to merge 29 commits into
developfrom
fix_LUT_twophase

Conversation

@EvertBunschoten

Copy link
Copy Markdown
Member

Proposed Changes

Improved the code structure for table generation, made the table generators for NICFD and FGM more object-oriented, allowing for easier integration of new refinement methods and applications, and makes the code easier to read and use.

New features to the tabulation base class:

  • Supports 2D and 3D tables depending on the number of controlling variables in the config.
  • Refine 2D table or table level based on target number of nodes, making it easier to control the size of the table.
  • Refine within specified bounds of thermochemical variables interpolated on the table nodes.
  • Option to smooth the data in the table in order to improve convergence in CFD simulations.
  • Manually specify table level values for 3D tables.
  • Write VTK file of the 2D table or table levels so the table content can be inspected with ParaView.

New features to the FGM tabulation class:

  • Scale refinement based on the gradients of thermochemical state variables. This can be useful for things like chemical source terms, which are difficult to interpolate accurately.
  • Apply additional refinement in chemical equilibrium.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • I have updated the list of python modules in required_packages.txt and environment.yml, if necessary.
  • I have properly commented my changes.
  • I have updated the documentation, if necessary.
  • I have added a test case that demonstrates my contribution, if necessary.

@EvertBunschoten EvertBunschoten changed the title Fix lut twophase New tabulation framework Jun 24, 2026
@EvertBunschoten EvertBunschoten self-assigned this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant