Skip to content

Reduce redundant CUDA Jacobian uploads during a linear solve #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LwhJesse wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −2
Draft

Reduce redundant CUDA Jacobian uploads during a linear solve #2806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c69f7
Reduce redundant CUDA Jacobian uploads
LwhJesse Apr 30, 2026
71e26d0
Move CUDA Jacobian upload into CSysMatrixVectorProduct
LwhJesse May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Common/include/linear_algebra/CMatrixVectorProduct.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,11 @@ class CSysMatrixVectorProduct final : public CMatrixVectorProduct<ScalarType> {
*/
inline CSysMatrixVectorProduct(const CSysMatrix<ScalarType>& matrix_ref, CGeometry* geometry_ref,
const CConfig* config_ref)
: matrix(matrix_ref), geometry(geometry_ref), config(config_ref) {}
: matrix(matrix_ref), geometry(geometry_ref), config(config_ref) {
#ifdef HAVE_CUDA
if (config->GetCUDA()) matrix.HtDTransfer();
#endif
}

/*!
* \note This class cannot be default constructed as that would leave us with invalid pointers.
Expand Down
1 change: 0 additions & 1 deletion Common/src/linear_algebra/CSysMatrixGPU.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ void CSysMatrix<ScalarType>::GPUMatrixVectorProduct(const CSysVector<ScalarType>
ScalarType* d_vec = vec.GetDevicePointer();
ScalarType* d_prod = prod.GetDevicePointer();

HtDTransfer();
vec.HtDTransfer();
prod.GPUSetVal(0.0);

Expand Down
Loading