Added custom HTML block for raw HTML or view insertions into form.#5
Merged
Added custom HTML block for raw HTML or view insertions into form.#5
Conversation
simonrjones
requested changes
Apr 10, 2026
|
|
||
| {# Custom HTML block #} | ||
| {%- block custom_html_block_row -%} | ||
| {%- if html is not empty -%}{{ html }}{%- endif -%} |
Member
There was a problem hiding this comment.
I don't think you need to test this do you? I thought Twig auto detected if variables are set and returns null if not.
Member
There was a problem hiding this comment.
Yes, it returns null unless strict_variables = true.
Member
Author
There was a problem hiding this comment.
That's been updated to remove the conditional now.
| use Symfony\Component\OptionsResolver\OptionsResolver; | ||
| use Twig\Markup; | ||
|
|
||
| class CustomHtmlBlockType extends AbstractType |
Member
There was a problem hiding this comment.
Can you rename to Html to make this easier to use? E.g.
>add('custom_block', Html::class, [
'view' => view('path.to.template', [
'my_twig_variable' => 'foobar'
])
])
Member
Author
There was a problem hiding this comment.
No problem, CustomHtmlBlockType has been renamed To Html. Just changes the usage and the twig template row block name (now html_row).
simonrjones
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Called in the form builder like so: