Skip to content

web: show error text on settings number input's out of range#9171

Merged
thecodrr merged 2 commits intomasterfrom
web/improve-settings-number-input
Apr 15, 2026
Merged

web: show error text on settings number input's out of range#9171
thecodrr merged 2 commits intomasterfrom
web/improve-settings-number-input

Conversation

@01zulfi
Copy link
Copy Markdown
Member

@01zulfi 01zulfi commented Jan 7, 2026

image

Comment thread apps/web/src/dialogs/settings/index.tsx Outdated
@01zulfi 01zulfi force-pushed the web/improve-settings-number-input branch from 7fea5d7 to df5aa72 Compare January 14, 2026 09:21
@01zulfi 01zulfi requested a review from thecodrr January 14, 2026 09:21
@thecodrr thecodrr added the plane label Apr 8, 2026
@thecodrr thecodrr changed the base branch from beta to master April 14, 2026 07:13
@thecodrr thecodrr force-pushed the web/improve-settings-number-input branch from df5aa72 to 7a67958 Compare April 14, 2026 07:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

Cloudflare Pages Preview

https://f4580675.notesnook-app.pages.dev

Commit: 0c867ea

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

Desktop Previews

Commit: 0c867ea

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

01zulfi and others added 2 commits April 15, 2026 08:04
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
@thecodrr thecodrr force-pushed the web/improve-settings-number-input branch from 951a444 to 299415c Compare April 15, 2026 03:04
@thecodrr thecodrr merged commit 4e2fd9d into master Apr 15, 2026
7 checks passed
@thecodrr thecodrr deleted the web/improve-settings-number-input branch April 15, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants