This repository was archived by the owner on Jan 24, 2024. It is now read-only.
fix: ListOffset interface returns an incorrect result#1747
Open
keyboardbobo wants to merge 1 commit intostreamnative:branch-2.9.2.24from
Open
fix: ListOffset interface returns an incorrect result#1747keyboardbobo wants to merge 1 commit intostreamnative:branch-2.9.2.24from
keyboardbobo wants to merge 1 commit intostreamnative:branch-2.9.2.24from
Conversation
The commit offset and partition data expire at the same time, and the ListOffset interface returns an incorrect result
eolivelli
reviewed
Mar 6, 2023
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
This is an interesting finding.
I am not sure that we can build a test.
How did you test that this fix actually fixed the problem ?
Contributor
Author
@eolivelli
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit offset and partition data expire at the same time, and the ListOffset interface returns an incorrect result
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #1737
Motivation
The commit offset and partition data expire at the same time, and the ListOffset interface returns an incorrect result
Modifications
If all the data expires, the entry of lac becomes -1, and the actual offset will be 1 smaller than LATEST, add 1 back
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)