Skip to content

The remote? method should allow for files with http in their names#214

Open
hlascelles wants to merge 1 commit intostreamio:masterfrom
bambooengineering:remote-should-allow-for-http-string-in-filenames
Open

The remote? method should allow for files with http in their names#214
hlascelles wants to merge 1 commit intostreamio:masterfrom
bambooengineering:remote-should-allow-for-http-string-in-filenames

Conversation

@hlascelles
Copy link

If a filename has an http(s) in the name it is mistaken for a remote:

# filename: /tmp/movie_of_http_webpage.mov

# Run:

     Failure/Error: response = http.request_head(url.request_uri)
     
     NoMethodError:
       undefined method `request_uri' for #<URI::Generic:0x00005640e7574d78>

The search for http(s) should be at the start of the string.

@hlascelles hlascelles changed the title The remote? method should allow for fils with http in their names The remote? method should allow for files with http in their names Nov 20, 2020
@hlascelles
Copy link
Author

@streamio Do you need any more information on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant