Fix install.sh error when cwd equals INSTALL_DIR#18
Merged
Conversation
When strawhub runs install.sh, it sets cwd to the package directory which is the same as INSTALL_DIR. The mv command fails with "'binary' and 'target/binary' are the same file". Skip the mv when source and destination resolve to the same absolute path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mv: 'binary' and 'target/binary' are the same fileerror during first-time installinstall.sh, it sets cwd to the package directory (same asINSTALL_DIR). Themvfails because source and destination are the same file.mvwhen both paths resolve to the same absolute pathTest plan
strawhub installno longer shows the error🤖 Generated with Claude Code