sv1: return errors instead of panicking in MerkleNode TryFrom#2084
Merged
GitGab19 merged 1 commit intostratum-mining:mainfrom Feb 16, 2026
Merged
Conversation
Shourya742
approved these changes
Feb 15, 2026
GitGab19
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
While reading
sv1/src/utils.rs, I noticed thatMerkleNodeparsing usedunwrap()in twoTryFromimplementations.That means bad input could panic instead of returning a normal error.
This PR replaces those
unwrap()calls with proper error handling, so invalid input returnsErrsafely.Changes made
TryFrom<Vec<u8>> for MerkleNodeTryFrom<&str> for MerkleNodemerkle_node_try_from_vec_invalid_len_returns_errmerkle_node_try_from_str_invalid_len_returns_errWhy this helps
TryFromshould fail gracefully, not panic.This makes the API behavior safer and more predictable for callers.
Notes
This is my beginner contribution, so I kept the change small and focused.
Happy to improve anything based on review feedback.