Add codec benches by Shourya742 · Pull Request #2058 · stratum-mining/stratum

Shourya742 · 2026-01-26T10:23:26Z

closes: #2060

Alkamal01 · 2026-03-12T16:44:30Z

Hey, just reviewing the benchmarks so far, looks great!
One thing I noticed: in bench_frame_serialize_and_create, a Vec is allocated inside the iter() loop. This might include allocation overhead in the timing results.
Would it make sense to pre-allocate the buffer outside the loop or use black_box to isolate serialization performance?
Happy to help with a small PR if that would be useful.

Shourya742 · 2026-03-24T08:06:23Z

Oopsie, I didn't pushed my local head.

lucasbalieiro · 2026-03-27T13:34:07Z

+            let mut total = Duration::ZERO;
+            for _ in 0..iters {
+                let mut enc = Encoder::<TestMsg>::new();
+                let held: Vec<_> = (0u8..8)


you are getting this (0u8..8) from the POOL_CAPACITY in buffer_sv2?

stratum/sv2/buffer-sv2/src/buffer_pool/mod.rs

Line 58 in 47b9f92

pub const POOL_CAPACITY: usize = 8;

If yes, I would encourage to get this value from the crate itself. If we ever change this capacity, the bench will become silently outdated. Also apply this in the other places that we need

Its not exposed publicly to downstream crates. Opened an issue: #2130

lucasbalieiro · 2026-03-27T13:58:14Z

+                        drop(held);
+                    }
+
+                    eprintln!(


this seems unusual. was it intentional to add here? or is just a leftover?

Yeah, I agree. I just couldn’t come up with a better way to observe the allocations and deallocations during these operations. I might remove them later if I find a cleaner approach.

lucasbalieiro

tACK 5901a68

The two open remaining points are non-blockers for me: #2058 (comment) and #2058 (comment)

Shourya742 force-pushed the 2026-01-26-add-codec-benches branch 2 times, most recently from ae5e79e to 043beed Compare March 12, 2026 08:00

Shourya742 marked this pull request as ready for review March 12, 2026 08:00

Shourya742 force-pushed the 2026-01-26-add-codec-benches branch 2 times, most recently from a45c2a6 to a2791e9 Compare March 12, 2026 08:02

Shourya742 requested a review from lucasbalieiro March 12, 2026 08:08