Fix Issues discovered while stress testing#1858
Merged
Conversation
…e.csv to calculate throughput
…s to avoid "encoding with 'idna' codec failed" err
…e.csv to calculate throughput
…s to avoid "encoding with 'idna' codec failed" err
… alya/immune/stress_testing # Conflicts: # slips_files/common/abstracts/icore.py # slips_files/core/database/redis_db/constants.py # slips_files/core/database/redis_db/database.py # slips_files/core/input.py
…onsumers OOM issue
…e.csv to calculate throughput
…s to avoid "encoding with 'idna' codec failed" err
…onsumers OOM issue
… alya/immune/stress_testing # Conflicts: # slips_files/core/profiler.py
… an equivalent wall clock time
…ndle pcaps starting at non zero ts
…n as slips stops, save to output/plots/
…pped, until the stop msg is received. to avoid shutting down profilers early as soon as input stops (usually input stops early and profilers cont. profiling until all flows are analyzed by them)
…y after optimizations
…isable performance plots in the output dir
…ce_plots param is enabled in slips.yaml, to avoid unecessary processing.
…ocesses to avoid using mp manager() because it's incapable of shutting down when slips is terminating
…ed dict to avoid the hassle
… to make sure profilers are started before sending the stop msgs
…tests not stopping in GH CI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1311, #1837, #1339, #1848
Speedup the processing of evidence by starting multiple EvidenceHandlerWorker processes in parallel.
Optimize and refactor localnet detection logic.
Reduced the default number of profiler workers started at launch from 5 to 3, with the existing scaling logic still available.
Changed network discovery to consume new_flow events instead of tw_modified, to avoid depending on the pub sub published msgs per flows for portscan checks. (main latency bottleneck)
Added a generate_performance_plots parameter to enable/disable performance plots.
Added performance instrumentation for input, profiler workers, and evidence handling to record throughput and latency data in output/performance_plots/csv/.
Added a Plotter to generate plots on shutdown and log throughput/latency metrics to metrics.txt.
Added a stress-testing docs documenting baseline, sudden spikes and soak testing.
Handle divide-by-zero case in progress reporting in slips/main.py.