Open
Conversation
Now each `(check-sat)` command is preceded by several `(set-info ...)` commands specifying the provenance of the check being performed, including a message to issue if the check yields `unsat`. Along the way, refactor verification options a bit and make it possible to specify the location where VCs are written when running StrataVerify.
Contributor
andrewmwells-amazon
left a comment
andrewmwells-amazon
left a comment
There was a problem hiding this comment.
Can these changes be tested on the examples in StrataTest/Languages/Python/expected/?
|
|
||
| failed=0 | ||
|
|
||
| (cd ../../.. && lake exe strata --help > /dev/null) |
Contributor
There was a problem hiding this comment.
What's the purpose of this?
Contributor
Author
There was a problem hiding this comment.
This causes strata to be built once, at which point we don't need the overhead of lake exe later.
andrewmwells-amazon
previously approved these changes
Feb 13, 2026
Contributor
Author
I believe they are being tested on those examples as part of normal CI? |
aqjune-aws
previously approved these changes
Feb 13, 2026
Contributor
aqjune-aws
left a comment
aqjune-aws
left a comment
There was a problem hiding this comment.
The new --vc-directory and also the removal of redundant solver flags look good.
atomb
dismissed stale reviews from aqjune-aws and andrewmwells-amazon
via
80b81ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consists of several additional commands before every
(check-sat)command.(set-info :file "<path>")where<path>is the path to the original source file, extracted from metadata in the Strata artifact.(set-info :start <n>)where<n>is the starting character position in the original source file.(set-info :stop <n>)where<n>is the ending character position in the original source file.(set-info :unsat-message "<msg>")where<msg>is a message generated by Strata to be presented if the result of the(check-sat)command isunsat.The changes to files in
StrataTestare just to fix type errors caused by the refactoring in other files and probably don't need to be closely reviewed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.