Let Core use more generic Imperative.SMTUtils for discharging proof obligation#414
Open
aqjune-aws wants to merge 9 commits intomainfrom
Open
Let Core use more generic Imperative.SMTUtils for discharging proof obligation#414aqjune-aws wants to merge 9 commits intomainfrom
aqjune-aws wants to merge 9 commits intomainfrom
Conversation
… stuffs with Strata/DL/Imperative/SMTUtils.lean
In #377, there was supposed to be an extra lemma for sanity check of the new `List.occurrences` function. The original proof was initially written by hand, then Ramana Nagasamudram found out a much more concise proof using LLM. Adding his version in this commit and piggybacking this commit to this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There was duplicated code in Core's SMT verification condition discharger and more generic Imperative.SMTUtils. The latter one was virtually not being used, except examples in StrataTest. However, since the latter is more general, let Core use it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.