Skip to content

Clickable featured images, new 16x9 image size, outline style button fix#304

Open
RachelRVasquez wants to merge 2 commits into
strangerstudios:devfrom
RachelRVasquez:misc-bug-fixes
Open

Clickable featured images, new 16x9 image size, outline style button fix#304
RachelRVasquez wants to merge 2 commits into
strangerstudios:devfrom
RachelRVasquez:misc-bug-fixes

Conversation

@RachelRVasquez
Copy link
Copy Markdown
Collaborator

All Submissions:

Changes proposed in this Pull Request:

  • Resolved issue where "outline" style on button block was not changing border color when a different color was selected from the color picker setting.
  • Made featured images clickable on archives.
  • Added a new image size for 16:9 and applied that size for our grid view banners/post thumbnails.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Resolved issue where "outline" style on button block was not changing border color when a different color was selected from the color picker setting. Made featured images clickable on archives. Added a new image size for 16:9 and applied that size for our grid view banners/post thumbnails.

…ges on grid view, make banners/featured images clickable on archives, fix outline style buttons
@RachelRVasquez RachelRVasquez marked this pull request as ready for review May 22, 2026 18:33
Copy link
Copy Markdown
Contributor

@flintfromthebasement flintfromthebasement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: #304 — Clickable featured images, new 16x9 image size, outline style button fix
RachieVee → dev | 5 files, +16 -12
#304

Summary
Three independent improvements: a correct 16:9 image size addition, clickable archive thumbnails, and an outline button color fix. Ready to merge with one fix — the banner link in entry-header.php is missing guards present in the parallel content.php change.

Issues

  • Major components/post/entry-header.php:20-22 — The new <a> wrapping the banner image has two problems:

    1. No is_single() guard. entry-header.php renders on both archives and single post pages. On a single post, get_permalink() returns the current URL — a self-referential link with no visible label.

    2. No accessibility attributes on the link. The <img> inside is alt="" + aria-hidden="true", so the <a> has no accessible name. Keyboard users will tab to an unlabeled empty link.

    The parallel change in content.php handles both correctly — use it as the model:

    if ( ! is_single() ) {
        echo '<a href="' . esc_url( get_permalink() ) . '" tabindex="-1" aria-hidden="true">';
    }
    // ... img tag ...
    if ( ! is_single() ) {
        echo '</a>';
    }
  • Minor src/scss/blocks/_blocks.scss:201-202 — Removing border-color and color from .is-style-outline fixes the color picker override, but sites where no custom button color has been set will see a visual change (border/text will fall back to currentColor/inherited text color instead of the theme's --wp--preset--color--buttons). This is correct behavior, but worth calling out explicitly in the changelog as a visual change for default-configured buttons.

Looks Good

  • content.php handles the clickable thumbnail cleanly — tabindex="-1" and aria-hidden="true" on the link, is_single() guard, and the alt text lookup kept intact. Good pattern.
  • memberlite-16x9 (960×540, cropped center) is a sensible size for grid banners and consistent with the existing named-size convention.
  • get_post_thumbnail_id() without explicit $post->ID is fine inside the Loop; the refactor is cleaner.

@RachelRVasquez RachelRVasquez marked this pull request as draft May 26, 2026 18:59
…ing and showing an 'unlabeled empty link' to screen reader users, letting the title permalink be the focus.
@RachelRVasquez RachelRVasquez marked this pull request as ready for review May 27, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants