fix: s3session manager bug#1915
Merged
mehtarac merged 1 commit intostrands-agents:mainfrom Mar 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lizradway
approved these changes
Mar 16, 2026
lizradway
reviewed
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
S3SessionManager with the default empty prefix (prefix="") produces S3 keys with a leading slash (e.g., /session_abc/agents/agent_default/agent.json). S3-compatible backends like MinIO normalize keys by stripping leading slashes on write, but the SDK reads using the original key with the leading slash. This mismatch causes read_agent() to return None, so the agent always takes the new-session branch on restore — silently discarding previous conversation history.
A related issue exists when users pass a prefix with a trailing slash (e.g., prefix="sessions/"), which produces double slashes in keys (sessions//session_abc/...).
Related Issues
#1863
Documentation PR
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.