fix: pass config params to structured_output in OpenAIResponsesModel#1910
Open
Di-Is wants to merge 2 commits intostrands-agents:mainfrom
Open
fix: pass config params to structured_output in OpenAIResponsesModel#1910Di-Is wants to merge 2 commits intostrands-agents:mainfrom
Di-Is wants to merge 2 commits intostrands-agents:mainfrom
Conversation
97470ae to
571d507
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenAIResponsesModel.structured_output()silently drops all config params (max_output_tokens,reasoning,instructions, etc.) because it only extracts["input"]from the_format_request()result.This fix builds
parse_kwargsfrom the full_format_request()output, excludingmodel/input(already handled explicitly) andstream(hardcoded asTrueby_format_request(), incompatible withparse()). Other params pass through directly, letting the API/SDK validate incompatible combinations.Resolves: #1908
Related Issues
#1908
Documentation PR
N/A
Type of Change
Bug fix
Testing
test_structured_output_passes_config_params— verifiesmax_output_tokensandreasoningare forwarded,streamis excludedtest_structured_output_passes_instructions— verifiessystem_promptis forwarded asinstructionsgpt-5.4thatresponses.parse()correctly acceptsmax_output_tokens,reasoning, andinstructionshatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.