Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/strands/event_loop/event_loop.py
Original file line number Diff line number Diff line change
Expand Up @@ -560,8 +560,9 @@ async def _handle_tool_execution(
if cycle_span:
tracer.end_event_loop_cycle_span(span=cycle_span, message=message, tool_result_message=tool_result_message)

agent.event_loop_metrics.end_cycle(cycle_start_time, cycle_trace)

if invocation_state["request_state"].get("stop_event_loop", False) or structured_output_context.stop_loop:
Comment on lines 561 to 565
agent.event_loop_metrics.end_cycle(cycle_start_time, cycle_trace)
yield EventLoopStopEvent(
stop_reason,
message,
Expand Down
48 changes: 48 additions & 0 deletions tests/strands/event_loop/test_event_loop.py
Original file line number Diff line number Diff line change
Expand Up @@ -1084,3 +1084,51 @@ async def test_invalid_tool_names_adds_tool_uses(agent, model, alist):
],
"role": "user",
}


@pytest.mark.asyncio
async def test_event_loop_metrics_recorded_before_recursion(
agent,
model,
tool,
agenerator,
alist,
):
model.stream.side_effect = [
agenerator(
[
{
"contentBlockStart": {
"start": {
"toolUse": {
"toolUseId": "t1",
"name": tool.tool_spec["name"],
},
},
},
},
{"contentBlockStop": {}},
{"messageStop": {"stopReason": "tool_use"}},
]
),
agenerator(
[
{"contentBlockDelta": {"delta": {"text": "test text"}}},
{"contentBlockStop": {}},
]
),
]

with unittest.mock.patch.object(agent.event_loop_metrics, "end_cycle") as mock_end_cycle:
stream = strands.event_loop.event_loop.event_loop_cycle(
agent=agent,
invocation_state={"request_state": {}},
)
events = await alist(stream)

# Verify end_cycle was called once for tool cycle, once for text cycle
assert mock_end_cycle.call_count == 2

# Verify the event loop completed successfully
tru_stop_reason, _, _, _, _, _ = events[-1]["stop"]
assert tru_stop_reason == "end_turn"
Comment on lines +1122 to +1134
Loading