STOP-5061 -- Fixed critical vulnerabilities#206
Open
SB-ChetanKorde wants to merge 3 commits intomasterfrom
Open
STOP-5061 -- Fixed critical vulnerabilities#206SB-ChetanKorde wants to merge 3 commits intomasterfrom
SB-ChetanKorde wants to merge 3 commits intomasterfrom
Conversation
SB-ChetanKorde
requested review from
bhaskarsontakke,
pareshb3089 and
prafullaAtSB
SB-ChetanKorde
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We got critical vulnerabilities to fix from this ui-kit repo.
#InsertIssueNumberHere
Description
we updated the ui-kit to resolve all critical vulnerabilities and then fixed remaining moderate/low severity vulnerabilities (mostly via dependency/security-related changes) and pushed them on fix-critical-vulnerabilities
How Has This Been Tested?
Note : This repo is working on node 12 version and also use python2.7 version which is outdated, still we resolved critical/potential vulnerabilities with existing versions. we install all packages using command : yarn install --ignore-engines (this way it will not give node-gyp error for old python syntax for print statement.)
Critical vulnerabilities are fixed-
Perform unit testing and verification as below -
Run storybook - yarn storybook
Run yarn build
Run yarn build.tw
Run yarn build.styles
Run yarn test