Skip to content

fix: role hierarchy enforcement in stoat.js (API/models) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mihaicm93 wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

fix: role hierarchy enforcement in stoat.js (API/models) #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
680ba9d
fix: role hierarchy enforcement in stoat.js (API/models)
mihaicm93 Feb 21, 2026
2eae5cf
signarure
mihaicm93 Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export type Events = {
serverDelete: [server: HydratedServer];
serverLeave: [server: HydratedServer];
serverRoleUpdate: [server: Server, roleId: string, previousRole: Role];
serverRoleRanksUpdate: [server: Server, ranks: string[]];
serverRoleDelete: [server: Server, roleId: string, role: Role];

serverMemberUpdate: [
Expand Down Expand Up @@ -279,7 +280,7 @@ export class Client extends AsyncEventEmitter<Events> {
this.#reconnectTimeout = setTimeout(
() => this.connect(),
this.options.retryDelayFunction(this.connectionFailureCount()) *
1e3,
1e3,
) as never;

this.#setConnectionFailureCount((count) => count + 1);
Expand Down
20 changes: 20 additions & 0 deletions src/events/v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ type ServerMessage =
role_id: string;
data: Partial<Role>;
}
| { type: "ServerRoleRanksUpdate"; id: string; ranks: string[] }
| { type: "ServerRoleDelete"; id: string; role_id: string }
| {
type: "UserUpdate";
Expand Down Expand Up @@ -719,6 +720,25 @@ export async function handleEvent(
}
break;
}
case "ServerRoleRanksUpdate": {
const server = client.servers.getOrPartial(event.id);
if (server && event.ranks) {
event.ranks.forEach((roleId: string, idx: number) => {
const role = server.roles.get(roleId);
if (role) {
server.roles.set(
roleId,
new ServerRole(client, server.id, roleId, {
...role,
rank: idx,
} as never),
);
}
});
client.emit("serverRoleRanksUpdate", server, event.ranks);
}
break;
}
case "ServerRoleDelete": {
const server = client.servers.getOrPartial(event.id);
if (server) {
Expand Down