Fix #204, allow :additional_collection to work with strong params#207
Open
viacommits wants to merge 1 commit intostffn:masterfrom
Open
Fix #204, allow :additional_collection to work with strong params#207viacommits wants to merge 1 commit intostffn:masterfrom
viacommits wants to merge 1 commit intostffn:masterfrom
Conversation
Contributor
|
Can you try not to make so many white-space changes in PRs. it makes it very difficult to see what actually was changed to the code. |
Contributor
Author
|
Sorry about that, I'm not sure why that happened. I think it may have been my text editor (Atom). In any case, only line 510 was substantially changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @tanelj's suggestion, fix a bug from
in_controller.rbto includeadditional_collectioninno_attribute_check_actionswhen using strong parameters.