Render templates using env before dereferencing#124
Open
RemiBardon wants to merge 1 commit intostepci:mainfrom
Open
Render templates using env before dereferencing#124RemiBardon wants to merge 1 commit intostepci:mainfrom
env before dereferencing#124RemiBardon wants to merge 1 commit intostepci:mainfrom
Conversation
1 task
Allows using `${{ env.anything }}` in `$ref`s.
See stepci/stepci#220 for a use case explanation.
RemiBardon
force-pushed
the
render-env-before-dereferencing
branch
from
b868250 to
8e46f3d
Compare
Member
Author
|
@mishushakov I implemented it without needing stepci/liquidless#12, with the solution I explained in stepci/liquidless#12 (comment). |
Member
Author
|
Even though tests are not processed in any way, I still added test cases to manually check that my implementation works (and it does). |
Member
Author
|
About stepci/liquidless#12, we could use json-schema-ref-parser's Edit: It doesn't work… because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows using
${{ env.anything }}in$refs.See stepci/stepci#220 for a use case explanation.
stepci/liquidless#12 needs to be merged before. Then I'll updateEdit: See #124 (comment)liquidlessand make sure my code works (I didn't check yet as I can't do it easily).