[chore]sdk-examples: fix broken py-stellar-base imports#2545
Open
ElliotFriend wants to merge 1 commit into
Open
[chore]sdk-examples: fix broken py-stellar-base imports#2545ElliotFriend wants to merge 1 commit into
ElliotFriend wants to merge 1 commit into
Conversation
Standing-correctness audit against py-stellar-base 14.1.1: learn/migrate/evm/smart-contract-deployment.mdx imported from the pre-v9 `stellar_sdk.soroban.*` sub-package, which no longer exists (the module layout is flat: `soroban_server`, `soroban_rpc`). `SorobanServer` is re-exported at the top level, so the import is now `from stellar_sdk import SorobanServer`. The second import (`TransactionStatus` from `stellar_sdk.soroban.soroban_rpc`) referenced a symbol that no longer exists under that name and was unused in the snippet, so it was removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Python example in the EVM migration documentation to align with py-stellar-base / stellar-sdk v14.1.1 by fixing the import path for SorobanServer.
Changes:
- Replace deprecated/broken imports from
stellar_sdk.soroban/stellar_sdk.soroban.soroban_rpcwith the v14.1.1-compatiblefrom stellar_sdk import SorobanServer. - Remove the unused
TransactionStatusimport (it is not referenced elsewhere in the snippet).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ElliotFriend
changed the title
|
Preview is available here: |
overcat
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctness audit against
py-stellar-basev14.1.1