feat(gmail): add forward command with tests and helpers#167
Closed
salmonumbrella wants to merge 23 commits intosteipete:mainfrom
Closed
feat(gmail): add forward command with tests and helpers#167salmonumbrella wants to merge 23 commits intosteipete:mainfrom
salmonumbrella wants to merge 23 commits intosteipete:mainfrom
Conversation
- Fix variable shadowing in DocsUpdateCmd (govet: shadow) - Extract formatAuto constant to satisfy goconst linter Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Cover the readTextInput function and file path expansion logic by testing DocsWriteCmd and DocsUpdateCmd with temp files. Also test error cases: non-existent file, empty file, and mutual exclusion of --text and --file flags. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Test that --index flag properly rejects zero and negative values with the expected error message. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Distinguish the update command from write by specifying it inserts text at a specific index position in the document. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add integration tests verifying isDayExpr() integration: - TestResolveTimeRangeWithDefaultsToTomorrowEndOfDay: verifies --to tomorrow expands to end-of-day (23:59:59.999999999) - TestResolveTimeRangeWithDefaultsToNowNoExpansion: verifies --to now does NOT expand to end-of-day (remains current time) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add boolTrue/boolFalse constants for string "true"/"false" values - Rename shadowed err variable to writeErr in test file Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Rename err to convertErr to avoid shadowing the err variable declared earlier in the function. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix shadow declaration lint error in forward test - Add edge case tests: HTML-only, custom subject, CC/BCC - Extract shared resolveSendFrom() helper to gmail_helpers.go - Remove redundant subject empty check (dead code) - Fix slice preallocation lint warnings - Add defaultAttachmentFilename constant to fix goconst lint Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Bumping this — we're actively using gogcli for AFGE union operations (email triage, member outreach, grievance management) and the forward command would be a big quality-of-life improvement for our workflow. Happy to help test if there's anything needed to move this along. |
Owner
|
Thanks for the contribution. I reviewed this against current Closing this older forward implementation as obsolete to avoid carrying a large conflicting duplicate. Focused follow-ups against the landed command are welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166
Summary
gmail forwardcommand to forward emails to specified recipientsresolveSendFrom()helper to reduce code duplication between send/forwardTest plan
go test ./...)🤖 Generated with Claude Code