-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: fix broken link #9706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
docs: fix broken link #9706
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
@Om-A-osc Please make sure you read the contribution guidelines and you shall pass all the checks for a PR to be approved . |
|
@SuYaSh-PaThAk04 is anything wrong in the pr ? |
You shall follow the PR format and also fill the TODOs |
|
@SuYaSh-PaThAk04 sorry for the incorrect PR format earlier, I’ve fixed it now. I’ve also updated the PR with the required details. Could you please review the latest changes and let me know if anything else needs to be adjusted, or merge it if everything looks good? |
Still you didn't mentioned that which issue It fixes there is no mention of any issue in this PR . Also the Format is not correct now also |
SuYaSh-PaThAk04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify the issue that it fixes
|
@SuYaSh-PaThAk04 There are no related issues. I was going through julia style guide and found that link was broken. So I thought lets fix it. It is a small thing. Should I raise a issue for this and then link a pr to it ? |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #0.
Description
This pull request:
Related Issues
No
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N/A — no AI assistance was used for this PR.
@stdlib-js/reviewers