Skip to content

Conversation

@Lokeshranjan8
Copy link
Contributor

Resolves #9416 .

Description

What is the purpose of this pull request?

This pull request:

  • add halfnormal/mode

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 12, 2026
@Lokeshranjan8 Lokeshranjan8 marked this pull request as draft January 12, 2026 07:28
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 12, 2026
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Lokeshranjan8
Copy link
Contributor Author

The test file name is incorrect right now. I’ll rename it correctly in the next commit.

Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 12, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/halfnormal/mode $\color{green}164/164$
$\color{green}+0.00%$
$\color{green}8/8$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}164/164$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Lokeshranjan8 Lokeshranjan8 marked this pull request as ready for review January 12, 2026 17:45
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 12, 2026
@Planeshifter Planeshifter self-requested a review January 12, 2026 19:56
Updated the README to clarify the mode for a half-normal distribution.

Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

Lokeshranjan8 and others added 8 commits January 13, 2026 14:02
…ude/stdlib/stats/base/dists/halfnormal/mode.h

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
…/test.native.js

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
…ples/c/example.c

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
…main.c

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
…ME.md

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
…ME.md

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
…main.c

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
…ME.md

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
Lokeshranjan8 and others added 3 commits January 13, 2026 14:04
…/types/test.ts

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Tracking issue for complete implementation of @stdlib/stats/base/dists/halfnormal package

3 participants