test: migrate math/base/special/cexp to ULP-based assertions - #14165
Open
Planeshifter wants to merge 1 commit into
Open
test: migrate math/base/special/cexp to ULP-based assertions#14165Planeshifter wants to merge 1 commit into
math/base/special/cexp to ULP-based assertions#14165Planeshifter wants to merge 1 commit into
Conversation
Replace relative-tolerance (EPS-scaled delta/tol) comparisons with `@stdlib/assert/is-almost-same-value` ULP-based assertions in both test.js and test.native.js. Measured minimum ULP thresholds (fixture set: pure_imaginary.json, general_complex.json): - test.js: 0 ULP for both real and imaginary components (exact match on the reference fixtures). - test.native.js: 1 ULP for the real component and the pure-imaginary imaginary component; 2 ULP for the general-complex imaginary component, mirroring the native implementation's pre-existing wider tolerance for that case. Resolves a part of #11352. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/cexptest cases from relative-tolerance (EPS-scaleddelta/tol) comparisons to ULP-based assertions using@stdlib/assert/is-almost-same-value, per the RFC in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.js.pure_imaginary.json,general_complex.json), confirmed deterministic across two consecutive local runs:test.js(pure JS implementation): 0 ULP for both the real and imaginary components (exact match against the reference fixtures).test.native.js(native addon): 1 ULP for the real component (both fixture sets) and the imaginary component of the pure-imaginary fixture set; 2 ULP for the imaginary component of the general-complex fixture set, mirroring the pre-existing native implementation's wider tolerance (2.0 * EPS) for that specific case.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
math/base/special/cexpwere changed; no other packages were touched.make test TESTS_FILTER=".*/math/base/special/cexp/.*"passes (2034/2034 for bothtest.jsand the native addon build oftest.native.js), andnpx eslintis clean on both files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written entirely by Claude Code (an automated, scheduled session), including discovering the candidate package, studying prior-art conversions (e.g.
math/base/special/cinv), rewriting the test assertions, and empirically determining the ULP thresholds above. It is left as a draft specifically so a human can review it before it is considered for merge, given issue #11352 encourages contributors to author these migrations manually.@stdlib-js/reviewers
Generated by Claude Code