Skip to content

bench: refactor to use string interpolation in utils/some#10866

Open
Sumithraju wants to merge 1 commit intostdlib-js:developfrom
Sumithraju:sumithra-8647
Open

bench: refactor to use string interpolation in utils/some#10866
Sumithraju wants to merge 1 commit intostdlib-js:developfrom
Sumithraju:sumithra-8647

Conversation

@Sumithraju
Copy link
Contributor

  • Replace string concatenation with @stdlib/string/format for benchmark name construction in utils/some

Resolves a part of #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the benchmark in @stdlib/utils/some to use @stdlib/string/format for benchmark name construction instead of string concatenation, consistent with the project's modernization effort

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted Claude Code to identify the relevant benchmark files and understand the project conventions. The proposed changes were reviewed and verified manually by myself.


@stdlib-js/reviewers

Refactor benchmark to use `@stdlib/string/format` for benchmark name
construction instead of string concatenation.
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 10, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
utils/some $\color{green}113/113$
$\color{green}+100.00%$
$\color{green}11/11$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}113/113$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants